feat: adding iam_identity_center_instance_arn attribute #36830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XS
terraform-aws-provider
bot
added
the
needs-triage
justinretzolk
added
enhancement
|
@justinretzolk how this pull request gets any reviews? At the moment it is showing "no reviews" |
terraform-aws-provider
bot
added
the
prioritized
added 2 commits
June 24, 2024 17:23
nam054
force-pushed
the
f-aws_quicksight_account_subscription-36782
branch
from
536325a
to
d67ad54
Compare
nam054
force-pushed
the
f-aws_quicksight_account_subscription-36782
branch
from
d67ad54
to
0b5c5dc
Compare
nam054
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
LGTM! 🚀
=== RUN TestAccQuickSight_serial
=== PAUSE TestAccQuickSight_serial
=== CONT TestAccQuickSight_serial
=== RUN TestAccQuickSight_serial/AccountSubscription
=== RUN TestAccQuickSight_serial/AccountSubscription/basic
=== RUN TestAccQuickSight_serial/AccountSubscription/disappears
--- PASS: TestAccQuickSight_serial (326.47s)
--- PASS: TestAccQuickSight_serial/AccountSubscription (326.47s)
--- PASS: TestAccQuickSight_serial/AccountSubscription/basic (165.25s)
--- PASS: TestAccQuickSight_serial/AccountSubscription/disappears (161.21s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 330.717s
|
This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to adding new attribute
iam_identity_center_instance_arnto resource typeaws_quicksight_account_subscriptionto able to configure from terraformRelations
If your pull request fully resolves and should automatically close the linked issue, use Closes. Otherwise, use Relates.
Closes #36782